search

alonbl / gnupg-pkcs11-scd

PKCS#11 GnuPG SCD
http://gnupg-pkcs11.sourceforge.net/
Other
68 stars 17 forks source link

Updated to allow for key padding #20

Closed mnkolev closed 2 years ago

mnkolev commented 5 years ago

We ran into an intermittent issue where the session key generated isn't always 2048b. Normally this isn't an issue but since we store our keys in the Luna CloudHSM, it expects an exact key size and thus rejects the request.

This minor code fix adds padding where needed for all key sizes.

alonbl commented 5 years ago

Why a new pull request? Please use the same [previous] branch and push with --force

alonbl commented 5 years ago

Please? just rename the branch name to your old branch name and push with --force

mnkolev commented 5 years ago

I had to create a new fork and PR based on a request that came in from open source contribution guidelines from above. Would we be ok with merging in this PR?

alonbl commented 5 years ago

You must work with git correctly, even for the review iterations... take it as opportunity to learn...

You should not have created a new fork... but even if you have, you can use the same branch, oh... I see you even deleted the previous repository... ok... very difficult to work this way

mnkolev commented 5 years ago

Correct, I had everything saved locally but was requested to do so and it made things a bit more difficult, I apologize.

mnkolev commented 5 years ago

Waiting on another approval from open source team, will make these changes in the mean time. Appreciate you looking over this

alonbl commented 2 years ago

Probably a bug in the HSM