aloneguid / bt

Browser Tamer
https://aloneguid.github.io/bt/
Apache License 2.0
134 stars 6 forks source link

Regex domain rule failed to load and operate properly #67

Closed liny01-nbsa closed 5 months ago

liny01-nbsa commented 6 months ago

Browser Tamer 3.6.2

The below configure to handle a local application like http://localhost:51139/ that the port number changes but starts with 5.

The rules are setup as

[browser:chrome:Default]
name = Yuan
arg = "%url%" "--profile-directory=Default"
user_arg = "--enable-features=IntelVpSuperResolution"
icon = C:\Users\liny01\AppData\Local\Google\Chrome\User Data\Default\Google Profile Picture.png
rule = scope:domain|type:regex|localhost:5....
rule = scope:domain|intel.com
rule = scope:domain|hemingwayapp.com

It works properly when it's just set

image

But after exit BT and start it again, this rule shows empty in the config box.

image

And it's loaded with the default browser.

aloneguid commented 6 months ago

Please try to put user_arg value in the UI instead: image

liny01-nbsa commented 5 months ago

@aloneguid I tried as you suggested, same issue.

image

The extra arg (user_arg is saved and loaded properly in UI)

aloneguid commented 5 months ago

Thanks for detailed report, looking at it now.

aloneguid commented 5 months ago

I've found the issue, anything with : in rule text will clear it. The fix is coming.

liny01-nbsa commented 5 months ago

That's great, @aloneguid , I'd be glad to help if any testing is needed.

aloneguid commented 5 months ago

@liny01-nbsa I'm taking you up on the offer :) Would be grateful if you can test it, download from https://github.com/aloneguid/bt/actions/runs/7714649868 (bin artifact). Seems to be OK on my side so far.

liny01-nbsa commented 5 months ago

Thank you for the fix, @aloneguid , the new build works for me too.

aloneguid commented 5 months ago

this is now released in 3.7.0

liny01-nbsa commented 5 months ago

Confirm the release tag 3.7.0 works as expected.