search

aloneguid / config

⚙ Config.Net - the easiest configuration framework for .NET developers. No BS.
MIT License
656 stars 86 forks source link

fixed incorrect collection reading for json and yaml #106

Closed feitzi closed 4 years ago

feitzi commented 4 years ago

fixes #105

If you read a collection value from a json or yaml file and it is not declared, the library returns an empty collection. If you have configured that value in a second store, that store will never be accessed because the first one returns "0". See the new test 'src/Config.Net.Json/Stores/JsonFileConfigStore.cs'

feitzi commented 4 years ago

@aloneguid please review :)

feitzi commented 4 years ago

@aloneguid No reaction for two months? Please give us feedback if you can continue to maintain this project in the future!

aloneguid commented 4 years ago

@feitzi it depends how much free time i can spend for free :) Please update the branch as it's out of sync and I'll merge.

feitzi commented 4 years ago

I understand what you mean :) Config.Net is, in my opinion, a really great project that should be much more popular in the .net community. But it's hard to convince other developers to use it when it's not regularly maintained.

PR is now updated