Incorrect parsing of double, float, decimal in Cultures without "." as decimal separator in JSON store

[ismdiego]

If you use a JSON store, you will face this problem with a config file like this:

{
   "num1": 2.5
}

If you execute this trivial code:

IAppSettings settings = new ConfigurationBuilder<IAppSettings>()
    .UseJsonFile(fileName)
    .Build();
var num1 = settings.num1;

// ...
public interface IAppSettings
{
    float num1 { get; set; }
}

You will find out that num1 == 0 (!!!!!). This is caused by a bug in GetStringValue method in JsonFileConfigStore which is using ToString() to convert back the read value into a string. This ToString() takes Culture into account, and so it converts 2.5 to "2,5" (notice the comma) in Cultures with that decimal separator (Spain, as in my case). Afterwards, the ValueHandler ParseValue method fails in the TryParse part because of that, and returns the default value (0 in this case).

This is easily fixed in JsonFileConfigStore changing:

private string GetStringValue(JToken token)
{
    if (token == null) return null;

    return token.ToString();
}

to:

private string GetStringValue(JToken token)
{
    if (token == null) return null;

    return token.Value<string>();
}

Can you please integrate this into the library? It is a safe change IMHO. And this is a really nasty bug...

As a temporary workaround, if you put:

{
   "num1": "2.5"
}

Then the parser works well... and the value is converted to float

[martin-braun]

I experience the same problem. My culture locale is "de-DE" and fractioned values will fail to parse properly. @aloneguid would you please apply the PR and publish a new version?

[martin-braun]

@aloneguid Thanks, it works, this can be closed.