aloneguid / config

⚙ Config.Net - the easiest configuration framework for .NET developers. No BS.
MIT License
641 stars 85 forks source link

Change JsonFileConfigStore #129

Closed aloslider closed 1 year ago

aloslider commented 2 years ago

Trying to resolve issue #128, so here's my thoughts and changes.

I tried to fix only my issue, but there could be probably more changes to this class, e.g. now ReadJsonFile() method doesn't have to check if file exists since it was already done in the constructor. Anyway, hope some of these changes are useful.

eveloki commented 2 years ago

It's been three months, why hasn't anyone worked on this change? Has this project been abandoned? I have this problem and he needs to be fixed。 image

WithAnOrchid commented 2 years ago

Seems this project needs urgent care, except for this bug, reading a large amount of config from JSON is quite slow.