search

aloneguid / config

⚙ Config.Net - the easiest configuration framework for .NET developers. No BS.
MIT License
656 stars 86 forks source link

Disabled AzureDevOpsVariableSetConfigStoreTest in a way where it stil… #137

Closed PockyBum522 closed 2 years ago

PockyBum522 commented 2 years ago

Disabled AzureDevOpsVariableSetConfigStoreTest in a way where it still shows up in tests runner, just as Inconclusive.

Left instructions on how to re-enable once it's implemented.

As far as I can tell, xunit does not have a way to skip the entire class, and skipping just the overridden method does not prevent exceptions from being thrown when all tests are run on the object that is now not set up properly.

If there's a better way to do this, I'm all ears.

It may also be an option to just change how the tests are set up so that [Fact(Skip = "reason")] works and doesn't let the ensuing tests run on the AzureDevOpsVariableSetConfigStoreTest class.

There may also just be a dumb reason why #if DEBUG isn't working in Rider for me.

I promise I did some research on xunit and figuring out how to ignore things, but unfortunately, I don't know what I don't know, which is quite a lot. Hence why I'm trying to get into collaboration and learn.

Please let me know if there's something I can do better. Right now I figure small, granular pull requests are better since you can pick and choose what to keep/drop.

aloneguid commented 2 years ago

this is removed altogether, thanks