aloneguid / parquet-dotnet

Fully managed Apache Parquet implementation
https://aloneguid.github.io/parquet-dotnet/
MIT License
542 stars 141 forks source link

ParquetTimestampAttribute has no effect on nullable DateTime properties #408

Closed aden-74 closed 5 months ago

aden-74 commented 9 months ago

The documentation says that to use non-legacy date type, we need to annotate a property with [ParquetTimestamp]:

[ParquetTimestamp]
public DateTime TimestampDate { get; set; }

Yes, this works. But it does not work when you use nullable DateTime, like the following:

[ParquetTimestamp]
public DateTime? TimestampDate { get; set; }

In this case, dates are serialized as INT96 numbers.

aloneguid commented 5 months ago

This is fixed in 4.23.0, please feel free to validate and re-open if any issues.