search

aloneguid / parquet-dotnet

Fully managed Apache Parquet implementation
https://aloneguid.github.io/parquet-dotnet/
MIT License
542 stars 141 forks source link

Exposed public classes under `System` namespace cause conflicts with other third party libraries #451

Closed dfaivre closed 5 months ago

dfaivre commented 6 months ago

Issue description

Specifically: https://github.com/aloneguid/parquet-dotnet/blob/eb82887fec926cc0f1faf025171bfe4825c1943e/src/NetBox.cs#L1914

It probably wouldn't collide as much but a lot of the functions are declared under the root System namespace - so they are automatically imported.

Could these classes/functions be made internal - or at least the ones declared in the System namespace?

Very useful project - thank you for all the work!

aloneguid commented 6 months ago

Good catch, thank you. They shutoff be all internal, it's a bug

aloneguid commented 5 months ago

released

dfaivre commented 5 months ago

Thank you!

On Thu, Jan 11, 2024 at 3:27 AM Ivan G @.***> wrote:

Closed #451 https://github.com/aloneguid/parquet-dotnet/issues/451 as completed.

— Reply to this email directly, view it on GitHub https://github.com/aloneguid/parquet-dotnet/issues/451#event-11453880064, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAJH27DGWRY2QVZBYUQBJNTYN6V7XAVCNFSM6AAAAABBR2UXWSVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJRGQ2TGOBYGAYDMNA . You are receiving this because you authored the thread.Message ID: @.***>

aloneguid commented 5 months ago

I'm glad you found it useful :) If you liked it, please consider giving it a star rating, it really makes a difference.

dfaivre commented 5 months ago

Done!