search

aloneguid / parquet-dotnet

Fully managed Apache Parquet implementation
https://aloneguid.github.io/parquet-dotnet/
MIT License
542 stars 140 forks source link

[BUG]: Error on deserializing not required DateTime properties #467

Closed VadymKuzin closed 5 months ago

VadymKuzin commented 5 months ago

Library Version

4.23.2

OS

Windows 10

OS Architecture

64 bit

How to reproduce?

  1. take parquet file which have not required int96 (datetime) column with some data
  2. create corresponding model for the parquet file where create corresponding property or field (actually does not matter) with datatype DateTime?
  3. Try to run ParquetSerializer.DeserializeAsync on these parquet file into this entity

image

image

image

From what I've understood the issue is somewhere here:

image

Because after I did this, my test passes, but not sure because it might break something else:

image

Failing test

No response

lizziebeans commented 5 months ago

Having the exact same problem. If you downgrade to 4.20.1 it works fine, so looks like a bug was introduced in the 4.22.0 release

VadymKuzin commented 5 months ago

Having the exact same problem. If you downgrade to 4.20.1 it works fine, so looks like a bug was introduced in the 4.22.0 release

Yep, currently working this way, just wanted to highlight the issue

aloneguid commented 5 months ago

Fixed in latest realease. Btw you can use Parquet Floor which matches versioning with the library itself.