Serialize nullable nullable types (#465)

aloneguid / parquet-dotnet

Fully managed Apache Parquet implementation

https://aloneguid.github.io/parquet-dotnet/

MIT License

542 stars 140 forks source link

Serialize nullable nullable types (#465) #468

Closed stefer closed 5 months ago

stefer commented 5 months ago

Attempt to detect nullable for any type. I am not sure how this relates to IsRequired and I have not added deserialization tests. Maybe tests should be added for all data types - I just added a few.

stefer commented 5 months ago

Hmm, yea, I could not run all unit tests locally (java references), so I missed these. I also think my solution was rather naive - we should probably look into the changes that where made for fields and see why that introduced regression. I need some more time if I should dig deeper.

aloneguid commented 5 months ago

Hey, I appreciate your hard work on this, it really helped me out. I made the changes you suggested and pushed them to the new version.