atodorov commented 4 years ago

@alorence let me know if the changes look good.

If possible would you make a small release to pick up these changes? We'd like to upgrade to Django 3 as soon as possible (or at least resolve this issue and continue patching other libraries if necessary).

coveralls commented 4 years ago

Coverage decreased (-2.5%) to 97.27% when pulling f128e3b0eeb82391c60924cb4e2fbc2b29a6ef64 on MrSenko:django_3 into 4a51b30918722046e463f2f8671df81bf89ca6b7 on alorence:master.

codecov[bot] commented 4 years ago

Codecov Report

Merging #31 into master will increase coverage by <.01%. The diff coverage is 100%.

@@            Coverage Diff             @@
##           master      #31      +/-   ##
==========================================
+ Coverage   99.72%   99.73%   +<.01%     
==========================================
  Files          38       38              
  Lines        2214     2262      +48     
==========================================
+ Hits         2208     2256      +48     
  Misses          6        6

Impacted Files	Coverage Δ
modernrpc/handlers/base.py	`100% <100%> (ø)`	:arrow_up:
modernrpc/compat.py	`100% <100%> (ø)`	:arrow_up:
modernrpc/utils.py	`100% <100%> (ø)`	:arrow_up:
modernrpc/auth/__init__.py	`100% <100%> (ø)`	:arrow_up:
modernrpc/tests/testsite/settings.py	`100% <100%> (ø)`	:arrow_up:
modernrpc/core.py	`100% <100%> (ø)`	:arrow_up:
modernrpc/handlers/xmlhandler.py	`100% <100%> (ø)`	:arrow_up:
modernrpc/tests/test_types.py	`95.91% <100%> (+0.02%)`	:arrow_up:
modernrpc/tests/test_basic.py	`100% <100%> (ø)`	:arrow_up:
modernrpc/auth/basic.py	`100% <100%> (ø)`	:arrow_up:
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4a51b30...f128e3b. Read the comment docs.

alorence commented 4 years ago

Thank you very much for the contribution. I will merge your PR in the next days, and perform all tests and docs + README update before publishing a new release. I will probably do this by the end of the week.

alorence commented 4 years ago

The new 0.12.0 release has just been published on https://pypi.org/project/django-modern-rpc/. It includes the PR you submitted 3 days ago. Let me know if you encounter any issue.

Best regards

alorence / django-modern-rpc

Changes around Django 3 #31

Codecov Report