fix: AuthenticationFailed not fired in batch requests

alorence / django-modern-rpc

Simple XML-RPC and JSON-RPC server for modern Django

http://django-modern-rpc.rtfd.io

MIT License

98 stars 17 forks source link

fix: AuthenticationFailed not fired in batch requests #35

Closed germancollado closed 2 years ago

germancollado commented 3 years ago

@alorence Can you take a look? Thanks a lot.

alorence commented 3 years ago

Hello,

Thank you for your feedback. Can you clarify what kind of issue this PR should solve?

Since this change will cause 3 tests to fail in all environment, I cannot merge it right now. In addition, this change does not respect the original behavior of the handler.

alorence commented 2 years ago

Hi, the recently published 1.0.0a1 updated the default behavior. Success or Error response is always returned inside a standard HttpResponse. No more 403 is returned to client, so the behavior is now the same for standard and batch request in case of authentication failure.

Feel free to test it and provide feedback if you have any issue. The goal is to ensure everything works fine before publishing the final stable release.