search

alorma / Compose-Settings

Compose Multiplatform #Compose Settings library
https://alorma.github.io/Compose-Settings/
MIT License
429 stars 27 forks source link

Fix publishing workflow #212

Closed jacobras closed 7 months ago

jacobras commented 7 months ago

Jobs inside a workflow run in parallel, so the publishing one never got any build output or even code. With this change there's just one publish job that checks out, builds and publishes. (The right build gets triggered automatically as a dependency from the publishing command).

alorma commented 7 months ago

Let's merge it, and try to release a new version

jacobras commented 7 months ago

Could you perform it by checking out the code in the publish job?

I would prefer it. As if build fails it will be easier to check.

These things can be annoying to test 😅 I did a publishKotlinMultiplatformPublicationToMavenLocal on my machine just to check basic compilation but that's not the hardest part of publishing.

alorma commented 7 months ago

Yes, i. know...

BTW, the release job failed because an "unauthenticated" request to sonatype... :S

jacobras commented 7 months ago

The current 401 on the URL seems to be getting us a step further. How old is your Sonatype account? Did you see the post-2021 configuration at https://github.com/gradle-nexus/publish-plugin#publishing-to-maven-central-via-sonatype-ossrh?

Couple of pointers on https://central.sonatype.org/faq/401-error/ might be useful as well.

P.S. I'm in the Kotlin slack @alorma , if you're also there we could chat quicker.