search

alovak / test_xml

Small library to test your xml with Test::Unit or RSpec
Other
30 stars 8 forks source link

Fix Output Order in RSpec Error Messages #11

Closed sshaw closed 10 years ago

sshaw commented 11 years ago

Prior to this failed assertions would indicated that the expected XML was the subject of the assertion.

I was using this commit for my testing, which adds a diff to the failed assertion message, something I think is a must, particularly for large XML docs. I made this change a while ago (just finally forked your repo and committed) and, if I recall, I think the diffing is naive and can lead to a confusing diff. At least it can be used as point of discussion.

sshaw commented 10 years ago

You going to pull these in?

alovak commented 10 years ago

@sshaw thanks!

sshaw commented 10 years ago

What do you think about adding a diffing library? Something like this (though I think the diff is not computed in an ideal way, and the message should probably just include the diff).

alovak commented 10 years ago

Hi! I think that it can be a good idea. Unfortunately I don't work with xml right now so I can't support this gem :( I have added you as collaborator so you make changes in the repo.

Thanks for your contribution!

apotonick commented 10 years ago

I like the idea of the diff lib, @sshaw !

sshaw commented 10 years ago

I'll try to add something this week.