search

alowaniak / music-replacer

Replace OSRS music tracks with user defined music
BSD 2-Clause "Simplified" License
9 stars 5 forks source link

Not working #4

Closed Vaksky closed 2 years ago

Vaksky commented 2 years ago

Won't pull song from youtube, and won't use local file as well after today's update.

alowaniak commented 2 years ago

My apologies for the late reply. I'm not entirely sure how local file couldn't have worked, are you sure you used a CD-quality .wav file? As that's currently the only format it can play.

Pulling songs from youtube should now work again though.

BLARGoMATIC commented 2 years ago

.wav files dont seem to be working or pulling from youtube.

The track is bold, but the music itself isn't being replaced.

alowaniak commented 2 years ago

Yesterday's osrs update indeed broke it (the Widget ID for the current playing song changed). I've committed a fix and made a PR to the plugin-hub, however the PR also contains other changes that might cause the approval to take longer.

I'll re-open the issue for now, but it should be fixed as soon as the PR is accepted.

dginovker commented 2 years ago

Seems to be working now, close?

alowaniak commented 2 years ago

Got indeed fixed a while back thanks for mentioning it.