search

aloysius-pgast / bittrex-signalr-client

Node.js implementation of SignalR protocol tailored for Bittrex exchange
39 stars 14 forks source link

Including missing orderbook update type ADD #16

Closed bolobox closed 6 years ago

bolobox commented 6 years ago

Hello,

According to bittrex documentation, there are 3 types of orderbook updates: ADD, REMOVE and UPDATE but implementation in this library only take REMOVE or UPDATE into account.

This pull request include the missing type (ADD)

aloysius-pgast commented 6 years ago

Hi. This was done on purpose because I think marking both updated entries and new entries as updated provides more valuable information than splitting in two distinct statuses. I'm closing the PR since it cannot be merged as-is (I want to keep backward compatibility and still think default should be to report new entries as an update) . If you really need to be able to distinguish between new entries and updated entries, I added a new option parameter markNewOrderBookEntriesAsUpdates. Setting it to false will allow you to have remove, add and update actions instead of just remove and update

bolobox commented 6 years ago

Great if the new behaviour could be configurable and backward compatible.

Thanks for your changes @aloysius-pgast