alpacahq / alpaca-py

The Official Python SDK for Alpaca API
https://alpaca.markets/sdks/python/getting_started.html
Apache License 2.0
558 stars 135 forks source link

Include the asof parameter for historical stock data requests #256

Closed didriknielsen closed 3 months ago

didriknielsen commented 1 year ago

Is there an existing issue for this?

Is your feature request related to a problem? Please describe.

The API references describe an asof parameter: https://alpaca.markets/docs/api-references/market-data-api/stock-pricing-data/historical/

However, this is not included in the various requests StockBarsRequest, StockTradesRequest, StockQuotesRequest, etc. of alpaca-py.

The same goes for the currency parameter.

Describe the solution you'd like.

Implement the asof (and currency) parameters in StockBarsRequest, StockTradesRequest, StockQuotesRequest, etc.

Describe an alternate solution.

No response

Anything else? (Additional Context)

No response

hiohiohio commented 3 months ago

This issue is resolved by https://github.com/alpacahq/alpaca-py/pull/477