search

alpacahq / alpaca-py

The Official Python SDK for Alpaca API
https://alpaca.markets/sdks/python/getting_started.html
Apache License 2.0
579 stars 146 forks source link

Update websockets to v11 #307

Closed impredicative closed 1 year ago

impredicative commented 1 year ago

Is there an existing issue for this?

Is your feature request related to a problem? Please describe.

Sometimes there are random errors when using websockets. Currently the version v10 is used. The goal is for the rate of errors to be minimized via the use of v11 of the websockets package.

Describe the solution you'd like.

No response

Describe an alternate solution.

No response

Anything else? (Additional Context)

No response

alessiocastrica commented 1 year ago

@impredicative thanks for flagging this, I made a PR.

haxdds commented 1 year ago

Fixed in 0.9.0

impredicative commented 1 year ago

Fixed in 0.9.0

@haxdds Hmm, this is not "fixed in 0.9.0". The websockets package is currently at version 10.4 in it.

Also, this is a very sensitive change request w.r.t. the affected functionality. IMHO it should be tested very well before a release.

haxdds commented 1 year ago

Sorry that's my mistake I thought we had merged it but it's currently in the staging branch. See #316

alessiocastrica commented 1 year ago

Fixed in 0.11