search

alpacahq / alpaca-py

The Official Python SDK for Alpaca API
https://alpaca.markets/sdks/python/getting_started.html
Apache License 2.0
537 stars 134 forks source link

fixing a couple bugs where the type isn't defaulted to none if the se… #351

Closed gageorsburn closed 11 months ago

gageorsburn commented 11 months ago

…rver doesn't provide the field

gageorsburn commented 11 months ago

@haxdds Looks like the CI is having issues and the test failure isn't related to this PR.

alessiocastrica commented 11 months ago

@gageorsburn thanks for the PR, it looks good to me but needs to be rebased, the CI issues have been solved in master. Also, please tag @hiohiohio instead of Rahul for reviews going forward.

gageorsburn commented 11 months ago

@hiohiohio @alessiocastrica Thanks for the update! The PR has been rebased :)