[Bug]: JournalStatus Enum is out of date with docs

RayOconnor commented 2 months ago

Is there an existing issue for this?

[X] I have searched the existing issues

Current Behavior

JournalStatus enum here is out of date with API documentation here:

Add an option for CORRECT = "correct".

Expected Behavior

CORRECT = "correct" is available for use.

SDK Version I encountered this issue in

0.19.0

Steps To Reproduce

1. import JournalStatus

Filled out the Steps to Reproduce section?

[X] I have entered valid steps to reproduce my issue or have attached a minimally reproducible case in code that shows my issue happening; and understand that without this my issue will be flagged as invalid and closed after 30 days.

Anything else?

I am an engineer working on my companies first integration with alpaca. I tried opening a pull request with this small requested change rather than opening a bug ticket, but I did not have permissions to contribute. I hope that you will consider granting me the ability to open pull requests to speed up bug resolution turn around time in the future.

hiohiohio commented 2 months ago

@RayOconnor thank you for the bug report and contributions. Could you please follow this guide to create a PR from fork?

hiohiohio commented 2 months ago

@RayOconnor I have created a PR for this issue. https://github.com/alpacahq/alpaca-py/pull/448

alpacahq / alpaca-py