search

alpacahq / alpaca-py

The Official Python SDK for Alpaca API
https://alpaca.markets/sdks/python/getting_started.html
Apache License 2.0
605 stars 150 forks source link

[FeatureReuest]: GetOptionContractsRequest.strike_price_lte returning data in ascending order #470

Open johnamcruz opened 5 months ago

johnamcruz commented 5 months ago

Is there an existing issue for this?

Current Behavior

When I use GetOptionContractsRequest.strike_price_lte the data is returned in ascending order. it's returning the option prices for the very last item instead of the first item that is closer to the strike price similar how the data is returned for strike_price_gte

Expected Behavior

When I use GetOptionContractsRequest.strike_price_lte the data is returned it should return the first item that is closer to the strike price.

SDK Version I encountered this issue in

latest version

Steps To Reproduce

call the request below 

req = GetOptionContractsRequest(
    underlying_symbols = [ "QQQ" ],                     # specify underlying symbols
    status = AssetStatus.ACTIVE,                                 # specify asset status: active (default)
    expiration_date = datetime.today.date()                                      
    type = "put",                                                # specify option type: put
    style = ExerciseStyle.AMERICAN,                              # specify option style: american
    strike_price_lte = "60.0",                                     # specify strike price range
    limit = 100,                                                 # specify limit
    page_token = None,                                           # specify page
)

res = trade_client.get_option_contracts(req)


### Filled out the Steps to Reproduce section?

- [X] I have entered valid steps to reproduce my issue or have attached a minimally reproducible case in code that shows my issue happening; and understand that without this my issue will be flagged as invalid and closed after 30 days.

### Anything else?

_No response_
hiohiohio commented 5 months ago

@johnamcruz Thank you for this report. I have changed this to FeatureRequest as currently we do not have this feature of changing order of response. I passed this feature request to the related people.

Current workaround is fetching all the data using page tokens and sort the responses by yourself unfortunately.