alpacahq / alpaca-trade-api-go

Go client for Alpaca's trade API
Apache License 2.0
320 stars 87 forks source link

Unused struct "Fundamental" confuses users #275

Closed mosaic-xlab closed 6 months ago

mosaic-xlab commented 6 months ago

Hello, I have an issue with this struct Fundamental as it is public, but actually dead code that is not referenced anywhere. I wasn't able to find any mention of Fundamental, or, more specifically, MarketCap field in the docs https://docs.alpaca.markets/reference.

It should be removed from the code, as it misleads to think that API provides market data such as MarketCap.

https://github.com/alpacahq/alpaca-trade-api-go/blob/c680bac85066e347c48c430c11cdd1c42ee13da5/alpaca/entities.go#L151-L175