Add missing fields to the Account model

alpacahq / alpaca-trade-api-go

Go client for Alpaca's trade API

Apache License 2.0

330 stars 93 forks source link

Add missing fields to the Account model #295

Open ankitsridhar16 opened 4 months ago

ankitsridhar16 commented 4 months ago

resolves #288

Account model is missing fields returned by the API

ankitsridhar16 commented 4 months ago

Options*

I have added the suggested changes to the PR @gcatlin can you review ?

gcatlin commented 4 months ago

@ankitsridhar16 Looks good. Thanks!

ankitsridhar16 commented 4 months ago

Please add / extend a unit test. If you do so, you will realise that the newly added fields are always empty, even when the server returns non-empty values for them. To fix that you'll need to regenerate the easyjson code with make generate.

I will check and ask if I have more doubts