Parse Order and Position entities

alpacahq / alpaca-ts

A TypeScript Node.js library for the https://alpaca.markets REST API and WebSocket streams.

ISC License

154 stars 42 forks source link

Parse Order and Position entities #12

Closed lbstr closed 3 years ago

lbstr commented 3 years ago

More progress on Issue #9 and a continuation of PR #10.

Parsing numbers and some strings in Order and Position
Improved error handling so user code gets a better message if something bad happens in the parse step
Improving types in a few params interfaces as well

117 commented 3 years ago

Looks like the prettier build step is still failing after updating the actions/checkout@v2.3.2 version. I'm gonna go ahead and just remove it for now. Can be added later a different way.

117 commented 3 years ago

I'm going to be a bit hands off with reviewing the merges into dev and will put a warning on the README.md that it is not recommended for use in a live environment.

lbstr commented 3 years ago

@117 That reminds me... I wanted to add something to the README explaining what we're doing here.

117 commented 3 years ago

@117 That reminds me... I wanted to add something to the README explaining what we're doing here.

Like an About section?

lbstr commented 3 years ago

Like an About section?

Maybe something in the Features section that you already have. Or maybe a new "Gotchas" section or something. Something like...

The Alpaca API uses strings for numeric values. For example, instead of responding with the number 12.34, Alpaca would provide this value as the string "12.34". In this package, we have decided to parse numeric strings into true JavaScript number primitives, so that you can immediately begin working with them.