search

alpacahq / alpaca-ts

A TypeScript Node.js library for the https://alpaca.markets REST API and WebSocket streams.
ISC License
154 stars 42 forks source link

Changed client method parameters to interfaces #2

Closed KalebMills closed 4 years ago

KalebMills commented 4 years ago

Because of the way the parameters were set up, there cannot be an abstract interface from this client. This adds the options as interfaces, so they can be referenced if an abstract class is created as I needed.

Note: If you'd like these interfaces in a separate file, or interface names changed, let me know and I will make those changes.

117 commented 4 years ago

The only thing I would change is rename them from Options to Parameters so GetWatchlistParameters instead of GetWatchlistOptions.

KalebMills commented 4 years ago

The only thing I would change is rename them from Options to Parameters so GetWatchlistParameters instead of GetWatchlistOptions.

Made that change