alpacahq / alpaca-ts

A TypeScript Node.js library for the https://alpaca.markets REST API and WebSocket streams.
ISC License
154 stars 42 forks source link

Update raw order to include order_class #84

Closed jdgriffith closed 2 years ago

jdgriffith commented 2 years ago

I noticed order_class was missing from RawOrder and the Order interface. Let me know if you would like me to make more changes to get this in.

117 commented 2 years ago

I had to revert the extension change 🙁 because of 83.

jdgriffith commented 2 years ago

No worries! You understand that issue better than me :)

And sorry that caused an issue for others. I would assume regardless of module type used the resolution would still work 🤔 I was actually playing around with your configuration locally this morning to see what config changes would help others. It's a tough issue since you are trying to support so many different types of targets (targets here being browsers, etc). I came up short...

117 commented 2 years ago

Will merge this weekend!

jdgriffith commented 2 years ago

Yay!

117 commented 2 years ago

Version 6.3.7 reflects this PR. Love to see the contributions!