search

alpacahq / alpaca-ts

A TypeScript Node.js library for the https://alpaca.markets REST API and WebSocket streams.
ISC License
156 stars 42 forks source link

Build Output Not Reflecting Recent PR #99

Closed tclare closed 2 years ago

tclare commented 2 years ago

Description Hey there! 🙂 Would you mind running the build output again to incorporate my most recent change (parsing the trade updates stream?) I don't think the .d.ts files are in sync with the most recent change. Led to a bug I caught recently where the code was sending a parsed form (TradeUpdate) to the handler but the old types were still in effect, TradeUpdate really referred to what is now known as a RawTradeUpdate. If you're low on time I can even do it, I can also open a PR tonight on the diff from running npm run build on the most recent version of master.

Expected Type declaration files (and thus IDE autocomplete) should sync up with my most recent changes parsing the Trade Update stream.

Reproduction Verify that the latest version of master inside does not have newly created interfaces in it. For instance, the @types/entities.d.ts file does not haveTradeUpdateEvent and RawTradeUpdate interfaces, and the @types/parse.d.ts file does not have the trade_update parser function type.

Logs n/a

Additional n/a

117 commented 2 years ago

Oops. Forgot that command. 🙃

117 commented 2 years ago

Alright, it's in 6.3.16.

tclare commented 2 years ago

Thanks for the quick attention!