alpacahq / marketstore

DataFrame Server for Financial Timeseries Data
Apache License 2.0
1.89k stars 232 forks source link

fix(timeframe): handle an error due to an invalid timeframe string #584

Closed dakimura closed 2 years ago

dakimura commented 2 years ago

WHAT

WHY

sonarcloud[bot] commented 2 years ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

codecov-commenter commented 2 years ago

Codecov Report

Merging #584 (af12b62) into master (4765454) will decrease coverage by 0.04%. The diff coverage is 45.00%.

@@            Coverage Diff             @@
##           master     #584      +/-   ##
==========================================
- Coverage   48.92%   48.88%   -0.05%     
==========================================
  Files         138      138              
  Lines       12875    12886      +11     
==========================================
  Hits         6299     6299              
- Misses       6030     6036       +6     
- Partials      546      551       +5     
Impacted Files Coverage Δ
contrib/ondiskagg/aggtrigger/aggtrigger.go 53.65% <30.00%> (-1.90%) :arrow_down:
frontend/query.go 51.19% <33.33%> (-0.62%) :arrow_down:
uda/adjust/caloader.go 84.13% <33.33%> (-1.18%) :arrow_down:
utils/timeframe.go 74.59% <100.00%> (ø)