Allow non-integral types in Vec generator constructor

[sliwowitz]

The explicit Vec(F&& generator, std::integer_sequence<TVal, Is...>) accepted a parameter pack of TVal which is defined to be the inner vector value and can possible be non-integral, which makes it invalid in pre-C++20 codebases. We've restricted the parameter to an integral type, thus disallowing this construction method for non-integral inner types.

[mehmetyusufoglu]

Is it possible to add a test for it?

[sliwowitz]

I suppose so. I've looked into the current Vec test, and it seems we're only testing integral types. Was this class ever supposed to handle floating point values?

[sliwowitz]

Seems @bernhardmgruber's idea works fine too. Does anyone have tips on what kind of additional tests to write for this? Maybe extend the current tests so that they'd consturct Vecs of additional types beside size_t, and add a test for the generator constructor (I can't see one in there)

[psychocoderHPC]

Seems @bernhardmgruber's idea works fine too. Does anyone have tips on what kind of additional tests to write for this? Maybe extend the current tests so that they'd consturct Vecs of additional types beside size_t, and add a test for the generator constructor (I can't see one in there)

Yes sounds good. We should have a test where a Vec<float,...> is created and for generators.

[bernhardmgruber]

Sure, please add tests for the generator constructor!

[bernhardmgruber]

@sliwowitz Could you please add a test so I can proceed merging this PR? Thanks!

[psychocoderHPC]

@sliwowitz ping

[sliwowitz]

Just a side note, Bernhard's solution actually allows non-integral types in the Vec generator constructor, so I renamed the PR to reflect that..