search

alpaka-group / alpaka

Abstraction Library for Parallel Kernel Acceleration :llama:
https://alpaka.readthedocs.io
Mozilla Public License 2.0
337 stars 69 forks source link

refactor template order `allocMappedBuf` #2270

Closed SimeonEhrig closed 1 month ago

SimeonEhrig commented 1 month ago

Move template TPlatform as the last template. There is no need to provide the platform template signature if we pass the platform as an instance.

follow up of #2162

psychocoderHPC commented 1 month ago

please update https://github.com/alpaka-group/alpaka/blob/8dbe7c42c647e4b67f22c10a39c36b160f654ecf/docs/source/dev/backends.rst?plain=1#L386 too. It was also forgotten during the change from platform type to platform instance.

Maybe we should use here allocMappedBufIfSupported()

psychocoderHPC commented 1 month ago

please update https://github.com/alpaka-group/alpaka/blob/8dbe7c42c647e4b67f22c10a39c36b160f654ecf/docs/source/dev/backends.rst?plain=1#L366 too

alpaka::allocMappedBuf<TElement>(host, platform, extents) 1D, 2D, 3D supported!
SimeonEhrig commented 1 month ago

please update

https://github.com/alpaka-group/alpaka/blob/8dbe7c42c647e4b67f22c10a39c36b160f654ecf/docs/source/dev/backends.rst?plain=1#L366 too

alpaka::allocMappedBuf<TElement>(host, platform, extents) 1D, 2D, 3D supported!

I alpaka::allocMappedBuf<TElement, TIdx>(host, platform, extents) 1D, 2D, 3D supported! should be correct.