search

alpaka-group / alpaka

Abstraction Library for Parallel Kernel Acceleration :llama:
https://alpaka.readthedocs.io
Mozilla Public License 2.0
337 stars 69 forks source link

Why is `AtomicAtomicRef` always disabled? #2287

Closed chillenzer closed 1 week ago

chillenzer commented 4 weeks ago

Hi, quick question: What's the reason for this line? Explicitly:

#ifndef ALPAKA_DISABLE_ATOMIC_ATOMICREF
#    define ALPAKA_DISABLE_ATOMIC_ATOMICREF
#endif

This ALWAYS AND UNCONDITIONALLY disables the AtomicAtomicRef path.

fwyzard commented 4 weeks ago

Ops...

It used to be wrong in a different way:

#ifndef ALPAKA_DISABLE_ATOMIC_ATOMICREF
#    if BOOST_VERSION < 107300
#        warning boost::atomic_ref requires Boost version 1.73 or higher. Please update your version of Boost, or disable the use of boost::atomic_ref with -DALPAKA_DISABLE_ATOMIC_ATOMICREF
#    endif
#    define ALPAKA_DISABLE_ATOMIC_ATOMICREF
#endif

Then, when we removed the Boost version check, we left the wrong definition.

fwyzard commented 4 weeks ago

https://github.com/alpaka-group/alpaka/pull/2288 should fix it.

psychocoderHPC commented 1 week ago

fixed with #2288 and #2294