fix clang9/nvcc11.2 boost bug

alpaka-group / alpaka

Abstraction Library for Parallel Kernel Acceleration :llama:

https://alpaka.readthedocs.io

Mozilla Public License 2.0

353 stars 72 forks source link

fix clang9/nvcc11.2 boost bug #2294

Closed psychocoderHPC closed 3 months ago

psychocoderHPC commented 3 months ago

This PR fix current CI issues with clang + nvcc and disable workarounds for C++20 and newer.

/boost/boost/atomic/detail/bitwise_cast.hpp(113): error: type name is not allowed

disable atomic_ref for clang<12&nvcc<11.6

The second commit fixes Windows compile issues those popped up today, maybe due to another MSVC update in the github workflow windows containers.

Issues introduced with #2288 where we enabled atomic ref after we introduced a bug that it was always disabled.

psychocoderHPC commented 3 months ago

@fwyzard You observed already in #2288 issues with clang+nvcc and due to #2296 it shows that more combinations are affected.

mehmetyusufoglu commented 3 months ago

This PR fix current CI issues with clang + nvcc and disable workarounds for C++20 and newer.
/boost/boost/atomic/detail/bitwise_cast.hpp(113): error: type name is not allowed
* disable atomic_ref for clang<12&nvcc<11.6
The second commit fixes Windows compile issues those popped up today, maybe due to another MSVC update in the github workflow windows containers.

Issues introduced with #2288 where we enabled atomic ref after we introduced a bug that it was always disabled.

@SimeonEhrig Do you think we can prepare a setup for that compiler configuration, i tried on HAL but current options not available. Being not able to test easily is preventing when we have a problem with nvcc11.2 and clang9/10 etc.

psychocoderHPC commented 3 months ago

This PR fix current CI issues with clang + nvcc and disable workarounds for C++20 and newer.
/boost/boost/atomic/detail/bitwise_cast.hpp(113): error: type name is not allowed
* disable atomic_ref for clang<12&nvcc<11.6
The second commit fixes Windows compile issues those popped up today, maybe due to another MSVC update in the github workflow windows containers. Issues introduced with #2288 where we enabled atomic ref after we introduced a bug that it was always disabled.
@SimeonEhrig Do you think we can prepare a setup for that compiler configuration, i tried on HAL but current options not available. Being not able to test easily is preventing when we have a problem with nvcc11.2 and clang9/10 etc.

Independent of this PR: In prinziple it is possible but you can always use the CI docker container to reproduce issues.

mehmetyusufoglu commented 3 months ago

This PR fix current CI issues with clang + nvcc and disable workarounds for C++20 and newer.
/boost/boost/atomic/detail/bitwise_cast.hpp(113): error: type name is not allowed
* disable atomic_ref for clang<12&nvcc<11.6
The second commit fixes Windows compile issues those popped up today, maybe due to another MSVC update in the github workflow windows containers. Issues introduced with #2288 where we enabled atomic ref after we introduced a bug that it was always disabled.
@SimeonEhrig Do you think we can prepare a setup for that compiler configuration, i tried on HAL but current options not available. Being not able to test easily is preventing when we have a problem with nvcc11.2 and clang9/10 etc.
Independent of this PR: In prinziple it is possible but you can always use the CI docker container to reproduce issues.

ok, i will try in the evening. I will document it if possible so that people can do easily....

mehmetyusufoglu commented 3 months ago

This PR fix current CI issues with clang + nvcc and disable workarounds for C++20 and newer.
/boost/boost/atomic/detail/bitwise_cast.hpp(113): error: type name is not allowed
* disable atomic_ref for clang<12&nvcc<11.6
The second commit fixes Windows compile issues those popped up today, maybe due to another MSVC update in the github workflow windows containers. Issues introduced with #2288 where we enabled atomic ref after we introduced a bug that it was always disabled.
@SimeonEhrig Do you think we can prepare a setup for that compiler configuration, i tried on HAL but current options not available. Being not able to test easily is preventing when we have a problem with nvcc11.2 and clang9/10 etc.
Independent of this PR: In prinziple it is possible but you can always use the CI docker container to reproduce issues.
ok, i will try in the evening. I will document it if possible so that people can do easily....

Ok works, great. Thank you good for compile errors.