search

alpaka-group / alpaka

Abstraction Library for Parallel Kernel Acceleration :llama:
https://alpaka.readthedocs.io
Mozilla Public License 2.0
337 stars 69 forks source link

Update catch2 version to 3.5.2 #2300

Open mehmetyusufoglu opened 1 week ago

mehmetyusufoglu commented 1 week ago

Update catch2 version from 3.3.2 to 3.5.2

The latest version 3.6.0 generated compile errors. Therefore 3.5.2 is selected which is the latest one that does not create compile errors. Compile error at unit and integration tests of Alpaka is related with changes in catch2/internal/catch_decomposer.hpp file of catch2 and observed only for nvcc11.0 and nvcc11.1 compilers. (https://gitlab.com/hzdr/crp/alpaka/-/jobs/7248169798) It seems nvcc mixes up__nv_bool and bool.

A fix of the at catch2 would be as in the diff file attached. (SOlution on the alpaka side is possible but would not worth for now) diff.txt

Currently reporting the bug and the possible solution to catch2 and using 3.5.2 instead of catch 3.6.0 is preferred.

SimeonEhrig commented 1 week ago

Please change the authorship of the commit, which updates the source code of Catch2. Here you can find how: https://github.com/alpaka-group/alpaka/pull/1815

mehmetyusufoglu commented 1 week ago

Please change the authorship of the commit, which updates the source code of Catch2. Here you can find how: #1815

Thanks, i changed the author of the commit ( although committed with my user-name).