alpaka-group / alpaka

Abstraction Library for Parallel Kernel Acceleration :llama:
https://alpaka.readthedocs.io
Mozilla Public License 2.0
353 stars 72 forks source link

Implement device functions to simplify writing kernel code [v2] #2369

Closed fwyzard closed 1 month ago

fwyzard commented 1 month ago

Implement device functions to simplify writing kernel code:

Implement tests for the most common functions.

fwyzard commented 1 month ago

I'm starting to hate Visual Studio...

D:\a\alpaka\alpaka\test\unit\exec\src\Once.cpp(133): FAILED:
  REQUIRE( *status == true )
with expansion:
  true == true
fwyzard commented 1 month ago

@psychocoderHPC all CI tests are finally happy... I can go on vacation :-)

ikbuibui commented 3 weeks ago

Sorry to comment on a merged PR, was there any reason why makeWorkDiv() was put in test/unit/exec/src? It seems like a useful interface

fwyzard commented 3 weeks ago

The current implementation makes some assumptions on how to us thread and elements. I have no problem moving it to a central place, but I don't know what @psychocoderHPC and @SimeonEhrig think of it.

ikbuibui commented 3 weeks ago

I noticed it also doesnt check if the work div is valid, correct? because elements can be greater than maxThreadsPerBlock

fwyzard commented 3 weeks ago

It's certainly possible.