alpaka-group / alpaka

Abstraction Library for Parallel Kernel Acceleration :llama:
https://alpaka.readthedocs.io
Mozilla Public License 2.0
356 stars 74 forks source link

Experimental support for oneAPI 2024.2 #2370

Closed fwyzard closed 2 months ago

fwyzard commented 3 months ago

The current oneAPI release is 2024.2, based on clang 19.

fwyzard commented 3 months ago

Due to the upstream clang updates this introduces a very large number of warnings, like

/home/fwyzard/src/alpaka-group/alpaka/include/alpaka/workdiv/WorkDivHelpers.hpp:229:13: warning: 'switch' missing 'default' label [-Wswitch-default]
  229 |             switch(gridBlockExtentSubDivRestrictions)
      |             ^

Is this something that we want to fix, by adding an empty default: label at the end of every switch statement ?

Or something that we could switch off ?

AuroraPerego commented 2 months ago

Is this something that we want to fix, by adding an empty default: label at the end of every switch statement ?

well.. 😅

/data/user/aperego/alpaka/include/alpaka/workdiv/WorkDivHelpers.hpp:224:4: warning: default label in switch which covers all enumeration values [-Wcovered-switch-default]
  224 |                         default:
      |                         ^

Or something that we could switch off ?

This works to silence the warning:

#    if BOOST_COMP_CLANG
#        pragma clang diagnostic push
#        pragma clang diagnostic ignored "-Wswitch-default"
#    endif

// ...

#    if BOOST_COMP_CLANG
#        pragma clang diagnostic pop
#    endif
fwyzard commented 2 months ago

warning: default label in switch which covers all enumeration values [-Wcovered-switch-default]

🤦🏻

fwyzard commented 2 months ago

Fixed by #2368.