remove boost as mandatory dependency

alpaka-group / alpaka

Abstraction Library for Parallel Kernel Acceleration :llama:

https://alpaka.readthedocs.io

Mozilla Public License 2.0

353 stars 72 forks source link

remove boost as mandatory dependency #2409

Open psychocoderHPC opened 17 hours ago

psychocoderHPC commented 17 hours ago

fix https://github.com/alpaka-group/alpaka/issues/481

Make boost an optional dependency. alpaka::core::demangled<TYPE> returns a mangled name in case boost is not available. https://github.com/alpaka-group/alpaka/issues/2405 can solve this but should not be mixed into this PR. This PR removes the mixing of alpakas own defines e.g BOOST_LANG_HIP which looked like boost but was exposed by alpaka under BOOST names.

This PR is a base for discussion at the next developer meeting. In a separate PR we could reduce the number of tested boost versions. We should also run tests without boost at all.

SimeonEhrig commented 16 hours ago

@psychocoderHPC Can you please split up the PR. At least in two PR: remove boost::atomic_ref and the compiler detection.

At the moment it is nearly impossible to review it and I also saw, that you didn't modify the CI, which is definitively useful.

SimeonEhrig commented 16 hours ago

I think also a third PR with the demangling function names is useful.

psychocoderHPC commented 15 hours ago

Yes, I can do this after we discuss it in general.

SimeonEhrig commented 15 hours ago

Yes, I can do this after we discuss it in general.

You got me. I didn't read the description until the end :grimacing:

SimeonEhrig commented 14 hours ago

@psychocoderHPC Can you please short summarize the main changes?

If I'm not wrong the following boost features are used:

preprocessor defines for compiler detection
boost::atomic_ref if std::atomic_ref is not avaible
demangle type names

Did I missed something?