alpaka-group / cupla

C++ User interface for the Platform independent Library Alpaka :arrows_clockwise:
Other
37 stars 18 forks source link

Alpaka as 'git subtree' instead of 'git submodule' #103

Closed tdd11235813 closed 5 years ago

tdd11235813 commented 5 years ago

Changes Alpaka dependency workflow:

tdd11235813 commented 5 years ago

Edit: version to 0.2.0 ?

tdd11235813 commented 5 years ago

updated alpaka and rebased onto #104 to fix issue.

Note: rebasing with upstream lead git to be confused totally cuz of the submodule vs subtree (it mixed alpaka files with cupla files^^), re-adding subtree from scratch helped

ax3l commented 5 years ago

@tdd11235813 Pls note that we usually do not commit git subtree squashes under our own user name because it messes with the git statistics (e.g. you just authored 87k lines in cupla...). As an example, see: https://github.com/ComputationalRadiationPhysics/picongpu/pull/2893

tdd11235813 commented 5 years ago

yeah @psychocoderHPC also mentioned this offline today. Any suggestions for the mail address? Not sure whether it needs to be a valid one. I would like to suggest a more generic one instead of cupla@hzdr.de, because it also will affect other [upcoming] (beta-)projects too, and I do not want to create myriads of addresses. Maybe crp-git@hzdr.de or something like that? I would add your workflow to the INSTALL.md then.

psychocoderHPC commented 5 years ago

cupla@hzdr.de is fine but let us move to the generic address crp-git@hzdr.de and use it in all new projects.

ax3l commented 5 years ago

Sure, please update your instructions in INSTALL.md with it :)

tdd11235813 commented 5 years ago

ok, see PR #111