search

alpaka-group / cupla

C++ User interface for the Platform independent Library Alpaka :arrows_clockwise:
Other
37 stars 18 forks source link

Mark the TBB backend as "thread sequential" #105

Closed fwyzard closed 5 years ago

fwyzard commented 5 years ago

This lets CUPLA_KERNEL_OPTI swap the threads and elements when using the TBB backend, as it does for the serial and OpenMP ones.

sbastrakov commented 5 years ago

Looks good to me, but I'm no cupla expert. @psychocoderHPC what do you think?

psychocoderHPC commented 5 years ago

Thanks for the fix, it looks like I missed it where I introduced the TBB backend from alpaka.

psychocoderHPC commented 5 years ago

@fwyzard I changed the destination branch to dev. We move changes first to the dev branch and than with the release into the stable master.

Do you need the change in the last stable release? If so we can do a bug fix release on top of version 1.1

fwyzard commented 5 years ago

Do you need the change in the last stable release? If so we can do a bug fix release on top of version 1.1

Not at the moment - we are still looking at alpaka and cupla to figure out if they work well for us.