alpaka-group / cupla

C++ User interface for the Platform independent Library Alpaka :arrows_clockwise:

Other

37 stars 18 forks source link

Make Cupla header-only #109

Closed fwyzard closed 5 years ago

fwyzard commented 5 years ago

Move the implementation of the Driver and of the API to the respective header files.

fwyzard commented 5 years ago

This PR is built on top of, and includes, #106 .

psychocoderHPC commented 5 years ago

@fwyzard Thanks for the pull request. We discussed offline that we like to keep the possibility to have different cpp files (to support parallel builds) and like to have the possibility to use the code as header only project. We started for that the issue: https://github.com/ComputationalRadiationPhysics/cupla/issues/108

Your current suggestion has side effects on the compile time if cupla is used in a large project. I will keep this PR open and provide also a PR next week then we can discuss the dis/advantages of both implementations and side what we will merge.

ax3l commented 5 years ago

Just to clarify: we like the proposal and want to implement header-only vs. partly pre-compiled side-by-side, for the sake of compile time.

For our projects, we try to reduce header-only where possible for faster development cycles and try to speed up header-only parts with PCH and C++ modules.

psychocoderHPC commented 5 years ago

@fwyzard Sry for the delay. I implemented the header-only, standalone header in #112

tdd11235813 commented 5 years ago

112 is now merged into dev branch and should provide the wanted feature. I hope it is ok, when I close this for you in this case. Please let us know if there are issues or other things that should be added to cupla :)

fwyzard commented 5 years ago

Sure, and thanks for merging #112.