search

alpaka-group / cupla

C++ User interface for the Platform independent Library Alpaka :arrows_clockwise:
Other
37 stars 18 forks source link

Adds float3 and int3 with make-functions. #118

Closed tdd11235813 closed 4 years ago

sbastrakov commented 4 years ago

@psychocoderHPC @tdd11235813 do you think this PR should be finished? Just a small fix is needed, literally 1 minute.

sbastrakov commented 4 years ago

Offline discussion with @psychocoderHPC : I will make a new PR with this functionality today.

ax3l commented 4 years ago

As a maintainer, you can also update the PR by pushing the missing commit.

sbastrakov commented 4 years ago

Pushed to the same branch. Ready for review.

psychocoderHPC commented 4 years ago

We will merge this PR but it is not very clean to implement float3 and int3 in the global space without making at least int3 compatible to cupla::dim3. Since I like to do larger refactoring after the release of cupla 0.2.0 this PR is fine as temporary solution.

sbastrakov commented 4 years ago

@psychocoderHPC I agree. In that future refactoring, we could perhaps make a class template for a 3d vector (how PMacc also does it) and use it for all cupla 3d vector types.

Sorry, found an issue with the PR, fixed and rebased.

sbastrakov commented 4 years ago

@psychocoderHPC btw this PR is similarly stuck in the CI.

sbastrakov commented 4 years ago

Since we could not resolve the CI issue, I made a clone of this PR in #154 and will close this one.