search

alpaka-group / cupla

C++ User interface for the Platform independent Library Alpaka :arrows_clockwise:
Other
37 stars 18 forks source link

update travis CMake to 3.15.4 #129

Closed psychocoderHPC closed 5 years ago

psychocoderHPC commented 5 years ago

update travis cmake version

This update is required for #128 to switch to the latest alpaka dev branch

ax3l commented 5 years ago

But #128 uses CMake 3.11.4+, shouldn't that be the version you also want in CI?

sbastrakov commented 5 years ago

@ax3l this is a good point. I guess the idea was that alpaka CI uses CMake 3.15.2 for some cofigurations.

ax3l commented 5 years ago

That seams itchy to me and I would update all requirements then. Explaining "all things but XY work with CMake 3.11.4 but some need 3.15.2+" to users is a communication nightmare.

But I think you misread the Alpaka PR. This is just an extra test for changed behaviour in CMake, which is fine.

Back to cupla CI: our CI should always (at least) test the oldest supported configuration, otherwise newer feature-requirements and silent dependency updates sneak in during development. Can you please update accordingly?

sbastrakov commented 5 years ago

@ax3l you are right, I did not understand that alpaka PR and so my explanation is wrong. @psychocoderHPC, I guess you know the reason for the change in this cupla PR?

psychocoderHPC commented 5 years ago

@ax3l Yes makes sense to test the oldest supported CMake version. At the point of creating the PR I was only focused to get it running. We should update the CI again and go back to the minimal version and increase also in the cupla CMake scripts the min version to 3.11.4