[WIP] allow to undefine `uint3`

alpaka-group / cupla

C++ User interface for the Platform independent Library Alpaka :arrows_clockwise:

Other

37 stars 18 forks source link

[WIP] allow to undefine `uint3` #134

Closed psychocoderHPC closed 4 years ago

psychocoderHPC commented 5 years ago

Currently, it is not possible to undefine the macro which is renaming uint3 to the cupla equivalent because we use uint3 in the macro to for blockIdx, ThreadIdx, ... By adding a two-staged renaming of uint3 the user is now allowed to undefine uint3 in the user code.

This PR is backward compatible.

[ ] test with PIConGPU
[x] fix macros in kernel.hpp e.g. CUPLA_KERNEL

psychocoderHPC commented 5 years ago

The macros in e.g. CUPLA_KERNEL must be refactored first because they use dim3 which has the same issue that the definition can not be removed. It looks like I need to clean up first some things.

sbastrakov commented 4 years ago

@psychocoderHPC seems like refactoring of CUPLA_KERNEL is done, maybe now this PR works?

psychocoderHPC commented 4 years ago

@psychocoderHPC seems like refactoring of CUPLA_KERNEL is done, maybe now this PR works?

I will skip it for the 0.2.0 release, it would require to much testing time.

psychocoderHPC commented 4 years ago

I will close this PR, with #161 we are able to use cupla without the renaming macro functions.