search

alpaka-group / vikunja

Vikunja is a performance portable algorithm library that defines functions operating on ranges of elements for a variety of purposes . It supports the execution on multi-core CPUs and various GPUs. Vikunja uses alpaka to implement platform-independent primitives such as reduce or transform.
https://vikunja.readthedocs.io/en/latest/
Mozilla Public License 2.0
14 stars 5 forks source link

Remove alpaka/test/acc/TestAccs.hpp #14

Closed SimeonEhrig closed 3 years ago

SimeonEhrig commented 3 years ago

Instead of alpaka/test/acc/TestAccs.hpp use alpaka/example/ExampleDefaultAcc.hpp. TestAccs.hpp is just for internal usage and not provided by a alpaka installation.

sliwowitz commented 3 years ago

alpaka/example/ExampleDefaultAcc.hpp is not present in alpaka 0.5.0 release, we might want to just copy it to vikunja if we want to support 0.5.0.

sbastrakov commented 3 years ago

Maybe it is more practical to wait a little bit until 0.6.0 release and then at some point switch to it in vikunja, and only then to make this change to ExampleDefaultAcc?

SimeonEhrig commented 3 years ago

alpaka/example/ExampleDefaultAcc.hpp is not present in alpaka 0.5.0 release, we might want to just copy it to vikunja if we want to support 0.5.0.

I missed this, because with the latest supported dev version the problem is solved. I think your suggestion is the easiest way. We add the header, release a alpaka 0.5.0 compatible version and remove it afterwards, if we go to alpaka 0.6.0

SimeonEhrig commented 3 years ago

Solved in #21