search

alpapaydin / Godot4-3D-Smooth-Destructible-Terrain

A basic demonstration of procedural smooth terrain generation in Godot 4 in 100 lines.
MIT License
14 stars 3 forks source link

Case for particle scene path in player script needs uppercased #1

Closed RancidMilkGames closed 7 months ago

RancidMilkGames commented 7 months ago

Itty bitty thing. line 52 in player.gd should be var particleScene := preload("res://Scenes/Player/mining_particles.tscn"). Currently "player" in the path isn't capitalized. I think Windows might also ignore this(?), but Linux users do have to fix it for it to work.

alpapaydin commented 7 months ago

Thanks, fixed now.

RancidMilkGames commented 7 months ago

Awesome! I was thinking about going the normal route of a pull request, but figured it was the tiniest thing in the world and some developers are weird about people making small contributions, especially non meaningful ones. Cool project by the way!

alpapaydin commented 7 months ago

Thank you so much! You are always welcome to contribute, also with new ideas.

RancidMilkGames commented 7 months ago

Whooo!!! First contribution! I should have sat down and figured out how to do that a little while ago, as I know I've run into a few other things I thought might be of benefit, but do now know the process so you're very likely to see me here and there. I also appreciate the positivity, thank you!!

RancidMilkGames commented 7 months ago

Haha, if my last message doesn't make sense, I forgot I even sent this message because it was a small capitalization fix. I made my first attempt at contributing to the Godot docs and just saw the word Godot and thought that it had been accepted.