Closed Rajil1213 closed 1 month ago
Attention: Patch coverage is 61.40351%
with 110 lines
in your changes missing coverage. Please review.
Project coverage is 57.33%. Comparing base (
7fe385d
) to head (d4fb22d
). Report is 4 commits behind head on main.
@@ Coverage Diff @@
## main #380 +/- ##
==========================================
+ Coverage 57.23% 57.33% +0.09%
==========================================
Files 253 254 +1
Lines 26716 26935 +219
==========================================
+ Hits 15291 15442 +151
- Misses 11425 11493 +68
Files with missing lines | Coverage Δ | |
---|---|---|
bin/bridge-client/src/args.rs | 0.00% <ø> (ø) |
|
crates/bridge-exec/src/errors.rs | 0.00% <ø> (ø) |
|
crates/bridge-tx-builder/src/errors.rs | 11.11% <ø> (ø) |
|
crates/tx-parser/src/deposit/deposit_tx.rs | 93.50% <100.00%> (+0.64%) |
:arrow_up: |
crates/evmexec/src/engine.rs | 65.67% <0.00%> (ø) |
|
crates/primitives/src/relay/util.rs | 96.42% <96.29%> (-0.22%) |
:arrow_down: |
crates/bridge-sig-manager/src/manager.rs | 92.79% <71.42%> (-0.68%) |
:arrow_down: |
crates/primitives/src/relay/types.rs | 63.04% <93.54%> (+14.65%) |
:arrow_up: |
crates/primitives/src/l1.rs | 80.14% <76.19%> (+1.78%) |
:arrow_up: |
crates/primitives/src/bridge.rs | 86.35% <83.33%> (-0.63%) |
:arrow_down: |
... and 3 more |
I"m adding one more check in the code so let's hold off on the merge till then.
Okay, I think we're all good to go on this PR.
Description
This PR adds several crucial bugfixes to get the deposit flow working which involves:
The withdrawal process might have some bugs too but since the process is similar, deferring any bugfixes in that flow to a later PR.
Type of Change
Checklist