alpenlabs / strata

Rust implementation of the Strata protocol
https://docs.stratabtc.org
Apache License 2.0
23 stars 1 forks source link

Bridge client bugfixes #380

Closed Rajil1213 closed 1 month ago

Rajil1213 commented 1 month ago

Description

This PR adds several crucial bugfixes to get the deposit flow working which involves:

The withdrawal process might have some bugs too but since the process is similar, deferring any bugfixes in that flow to a later PR.

Type of Change

Checklist

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 61.40351% with 110 lines in your changes missing coverage. Please review.

Project coverage is 57.33%. Comparing base (7fe385d) to head (d4fb22d). Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
crates/bridge-exec/src/handler.rs 0.00% 46 Missing :warning:
...n/bridge-client/src/modes/operator/task_manager.rs 0.00% 20 Missing :warning:
bin/bridge-client/src/modes/operator/bootstrap.rs 0.00% 18 Missing :warning:
crates/primitives/src/bridge.rs 83.33% 13 Missing :warning:
crates/primitives/src/l1.rs 76.19% 5 Missing :warning:
crates/primitives/src/relay/types.rs 93.54% 4 Missing :warning:
crates/bridge-sig-manager/src/manager.rs 71.42% 2 Missing :warning:
crates/evmexec/src/engine.rs 0.00% 1 Missing :warning:
crates/primitives/src/relay/util.rs 96.29% 1 Missing :warning:
@@            Coverage Diff             @@
##             main     #380      +/-   ##
==========================================
+ Coverage   57.23%   57.33%   +0.09%     
==========================================
  Files         253      254       +1     
  Lines       26716    26935     +219     
==========================================
+ Hits        15291    15442     +151     
- Misses      11425    11493      +68     
Files with missing lines Coverage Δ
bin/bridge-client/src/args.rs 0.00% <ø> (ø)
crates/bridge-exec/src/errors.rs 0.00% <ø> (ø)
crates/bridge-tx-builder/src/errors.rs 11.11% <ø> (ø)
crates/tx-parser/src/deposit/deposit_tx.rs 93.50% <100.00%> (+0.64%) :arrow_up:
crates/evmexec/src/engine.rs 65.67% <0.00%> (ø)
crates/primitives/src/relay/util.rs 96.42% <96.29%> (-0.22%) :arrow_down:
crates/bridge-sig-manager/src/manager.rs 92.79% <71.42%> (-0.68%) :arrow_down:
crates/primitives/src/relay/types.rs 63.04% <93.54%> (+14.65%) :arrow_up:
crates/primitives/src/l1.rs 80.14% <76.19%> (+1.78%) :arrow_up:
crates/primitives/src/bridge.rs 86.35% <83.33%> (-0.63%) :arrow_down:
... and 3 more

... and 16 files with indirect coverage changes

Rajil1213 commented 1 month ago

I"m adding one more check in the code so let's hold off on the merge till then.

Rajil1213 commented 1 month ago

Okay, I think we're all good to go on this PR.