alpenlabs / strata

Rust implementation of the Strata protocol
https://docs.stratabtc.org
Apache License 2.0
23 stars 1 forks source link

Enhancement/bridge task management #394

Closed Rajil1213 closed 1 month ago

Rajil1213 commented 1 month ago

Description

This PR:

Type of Change

Checklist

Related Issues

Closes STR-505

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 17.80822% with 180 lines in your changes missing coverage. Please review.

Please upload report for BASE (releases/0.1.0@13159fb). Learn more about missing BASE report.

Files with missing lines Patch % Lines
...n/bridge-client/src/modes/operator/task_manager.rs 0.00% 66 Missing :warning:
bin/strata-cli/src/seed/password.rs 0.00% 30 Missing :warning:
bin/strata-cli/src/seed.rs 0.00% 19 Missing :warning:
bin/strata-client/src/helpers.rs 0.00% 16 Missing :warning:
bin/datatool/src/main.rs 0.00% 15 Missing :warning:
bin/strata-cli/src/cmd/change_pwd.rs 0.00% 11 Missing :warning:
bin/strata-client/src/keyderiv.rs 0.00% 10 Missing :warning:
bin/bridge-client/src/modes/operator/bootstrap.rs 0.00% 9 Missing :warning:
crates/state/src/header.rs 0.00% 3 Missing :warning:
crates/state/src/block_validation.rs 0.00% 1 Missing :warning:
@@                Coverage Diff                @@
##             releases/0.1.0     #394   +/-   ##
=================================================
  Coverage                  ?   56.98%           
=================================================
  Files                     ?      256           
  Lines                     ?    27046           
  Branches                  ?        0           
=================================================
  Hits                      ?    15413           
  Misses                    ?    11633           
  Partials                  ?        0           
Files with missing lines Coverage Δ
bin/bridge-client/src/args.rs 0.00% <ø> (ø)
bin/strata-cli/src/constants.rs 100.00% <100.00%> (ø)
bin/strata-client/src/main.rs 0.00% <ø> (ø)
crates/bridge-sig-manager/src/manager.rs 93.70% <ø> (ø)
crates/bridge-tx-builder/src/context.rs 86.36% <ø> (ø)
crates/bridge-tx-builder/src/deposit.rs 95.79% <100.00%> (ø)
crates/bridge-tx-builder/src/operations.rs 96.42% <ø> (ø)
crates/btcio/src/writer/builder.rs 98.03% <100.00%> (ø)
crates/crypto/src/lib.rs 92.68% <100.00%> (ø)
crates/primitives/src/bridge.rs 86.30% <100.00%> (ø)
... and 18 more
Rajil1213 commented 1 month ago

can we have some elaboration as to why duty exec would fail and why retrying it is safe?

This is because of two reasons:

Rajil1213 commented 1 month ago

Rebased this PR accidentally from main instead of releases/1.0 (old habits). Closing this PR and creating a new one instead.