Closed Rajil1213 closed 1 month ago
Attention: Patch coverage is 17.80822%
with 180 lines
in your changes missing coverage. Please review.
Please upload report for BASE (
releases/0.1.0@13159fb
). Learn more about missing BASE report.
@@ Coverage Diff @@
## releases/0.1.0 #394 +/- ##
=================================================
Coverage ? 56.98%
=================================================
Files ? 256
Lines ? 27046
Branches ? 0
=================================================
Hits ? 15413
Misses ? 11633
Partials ? 0
Files with missing lines | Coverage Δ | |
---|---|---|
bin/bridge-client/src/args.rs | 0.00% <ø> (ø) |
|
bin/strata-cli/src/constants.rs | 100.00% <100.00%> (ø) |
|
bin/strata-client/src/main.rs | 0.00% <ø> (ø) |
|
crates/bridge-sig-manager/src/manager.rs | 93.70% <ø> (ø) |
|
crates/bridge-tx-builder/src/context.rs | 86.36% <ø> (ø) |
|
crates/bridge-tx-builder/src/deposit.rs | 95.79% <100.00%> (ø) |
|
crates/bridge-tx-builder/src/operations.rs | 96.42% <ø> (ø) |
|
crates/btcio/src/writer/builder.rs | 98.03% <100.00%> (ø) |
|
crates/crypto/src/lib.rs | 92.68% <100.00%> (ø) |
|
crates/primitives/src/bridge.rs | 86.30% <100.00%> (ø) |
|
... and 18 more |
can we have some elaboration as to why duty exec would fail and why retrying it is safe?
This is because of two reasons:
OperatorIdx
which is in the chainstate/params and guaranteed to be the same too. So the worst that can happen when we retry duties is that we send a transaction whose input UTXO has already been spent.Rebased this PR accidentally from main
instead of releases/1.0
(old habits). Closing this PR and creating a new one instead.
Description
This PR:
retry_counts
associated with a particular duty and discards duties after a user-configurable number of retries have occurredType of Change
Checklist
Related Issues
Closes STR-505