alpenlabs / strata

Rust implementation of the Strata protocol
https://docs.stratabtc.org
Apache License 2.0
23 stars 1 forks source link

Fixes for STR-522 #406

Closed delbonis closed 2 weeks ago

delbonis commented 1 month ago

Description

Something unclear is broken with the CSM stuff that's preventing us from correctly advancing the chain. This PR is incomplete and is trying to investigate and fix those issues.

Type of Change

Checklist

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 0% with 253 lines in your changes missing coverage. Please review.

Project coverage is 57.39%. Comparing base (0b0be55) to head (afa7267). Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
crates/consensus-logic/src/csm/worker.rs 0.00% 242 Missing :warning:
crates/state/src/sync_event.rs 0.00% 8 Missing :warning:
crates/consensus-logic/src/csm/config.rs 0.00% 3 Missing :warning:
@@            Coverage Diff             @@
##             main     #406      +/-   ##
==========================================
- Coverage   57.56%   57.39%   -0.17%     
==========================================
  Files         263      264       +1     
  Lines       27716    27792      +76     
==========================================
- Hits        15954    15951       -3     
- Misses      11762    11841      +79     
Files with missing lines Coverage Δ
bin/strata-client/src/helpers.rs 0.00% <ø> (ø)
bin/strata-client/src/l1_reader.rs 0.00% <ø> (ø)
...rates/consensus-logic/src/csm/client_transition.rs 61.93% <ø> (ø)
crates/consensus-logic/src/csm/ctl.rs 0.00% <ø> (ø)
crates/consensus-logic/src/csm/message.rs 0.00% <ø> (ø)
crates/consensus-logic/src/csm/state_tracker.rs 46.40% <ø> (ø)
crates/consensus-logic/src/duty/worker.rs 0.00% <ø> (ø)
crates/consensus-logic/src/fork_choice_manager.rs 0.00% <ø> (ø)
crates/consensus-logic/src/l1_handler.rs 0.00% <ø> (ø)
crates/consensus-logic/src/sync_manager.rs 0.00% <ø> (ø)
... and 4 more

... and 4 files with indirect coverage changes

delbonis commented 1 month ago

Here's what I've done so far:

delbonis commented 3 weeks ago

The actual issue was resolved, but these are still useful changes that are in service of longer term goals, so we should still wrap this up.

delbonis commented 2 weeks ago

Will address the other comments.