Minor trait syntax clarification for the analyzer

alpenlabs / strata

Rust implementation of the Strata protocol

Apache License 2.0

23 stars 1 forks source link

Description

There are a few instances where the analyzer gets confused about Sha256::new() calls. It should use the Digest trait, for which the call is valid. However, it seems to get hung up on the KeyInit trait used elsewhere for AES operations, for which the call would expect an argument.

This PR adds fully-qualified trait syntax to appease the analyzer and help improve sanity.

Type of Change

[ ] Bug fix (non-breaking change which fixes an issue)

[ ] New feature/Enhancement (non-breaking change which adds functionality or enhances an existing one)

[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

[ ] Documentation update

[ ] Refactor

Checklist

[x] I have performed a self-review of my code.

[x] I have commented my code where necessary.

[x] I have updated the documentation if needed.

[x] My changes do not introduce new warnings.

[ ] I have added tests that prove my changes are effective or that my feature works.

[x] New and existing tests pass with my changes.

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 56.86%. Comparing base (5700222) to head (45659b9). Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
bin/strata-cli/src/seed.rs	0.00%	2 Missing :warning:
bin/strata-cli/src/recovery.rs	0.00%	1 Missing :warning:

@@           Coverage Diff           @@
##             main     #407   +/-   ##
=======================================
  Coverage   56.86%   56.86%           
=======================================
  Files         257      257           
  Lines       27083    27083           
=======================================
  Hits        15401    15401           
  Misses      11682    11682

Files with missing lines	Coverage Δ
bin/strata-cli/src/recovery.rs	`0.00% <0.00%> (ø)`
bin/strata-cli/src/seed.rs	`0.00% <0.00%> (ø)`

... and 7 files with indirect coverage changes

alpenlabs / strata