alpenlabs / strata

Rust implementation of the Strata protocol
https://docs.stratabtc.org
Apache License 2.0
23 stars 1 forks source link

Zeroize seed #412

Closed AaronFeickert closed 1 month ago

AaronFeickert commented 1 month ago

Description

This PR ensures that seeds are zeroized after they are constructed from mnemonics.

Type of Change

Checklist

Related Issues

Partially addresses Jira ticket 497.

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 64.28571% with 5 lines in your changes missing coverage. Please review.

Project coverage is 57.27%. Comparing base (ed4013c) to head (585393c). Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
bin/strata-cli/src/seed.rs 64.28% 5 Missing :warning:
@@            Coverage Diff             @@
##             main     #412      +/-   ##
==========================================
+ Coverage   57.18%   57.27%   +0.08%     
==========================================
  Files         257      257              
  Lines       27144    27147       +3     
==========================================
+ Hits        15523    15549      +26     
+ Misses      11621    11598      -23     
Files with missing lines Coverage Δ
bin/strata-cli/src/seed.rs 53.02% <64.28%> (+0.66%) :arrow_up:

... and 6 files with indirect coverage changes