Functional tests: Bridge Deposits

storopoli commented 4 weeks ago

Description

Changes the default rollup_name to the official devnet alpenstrata.
Adds a bridge factory that can be used for further tests.
Adds the bridge deposit functional test for the happy path.

Type of Change

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature/Enhancement (non-breaking change which adds functionality or enhances an existing one)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation update
[ ] Refactor
[x] New or updated tests

Checklist

[x] I have performed a self-review of my code.
[x] I have commented my code where necessary.
[x] I have updated the documentation if needed.
[x] My changes do not introduce new warnings.
[x] I have added tests that prove my changes are effective or that my feature works.
[x] New and existing tests pass with my changes.

Related Issues

STR-483 STR-541 (especially a1943e85b876808117523a64554bd74f50c2a196)

codecov[bot] commented 4 weeks ago

Codecov Report

Attention: Patch coverage is 28.40909% with 63 lines in your changes missing coverage. Please review.

Project coverage is 57.66%. Comparing base (3b6129f) to head (a1943e8). Report is 17 commits behind head on main.

Files with missing lines	Patch %	Lines
crates/util/python-utils/src/taproot.rs	23.68%	58 Missing :warning:
crates/util/python-utils/src/error.rs	0.00%	2 Missing :warning:
crates/util/python-utils/src/lib.rs	0.00%	2 Missing :warning:
bin/datatool/src/main.rs	0.00%	1 Missing :warning:

@@            Coverage Diff             @@
##             main     #421      +/-   ##
==========================================
+ Coverage   57.60%   57.66%   +0.06%     
==========================================
  Files         263      263              
  Lines       27541    27634      +93     
==========================================
+ Hits        15864    15936      +72     
- Misses      11677    11698      +21

Files with missing lines	Coverage Δ
crates/util/python-utils/src/drt.rs	`84.93% <ø> (ø)`
crates/util/python-utils/src/parse.rs	`100.00% <100.00%> (ø)`
bin/datatool/src/main.rs	`0.00% <0.00%> (ø)`
crates/util/python-utils/src/error.rs	`0.00% <0.00%> (ø)`
crates/util/python-utils/src/lib.rs	`0.00% <0.00%> (ø)`
crates/util/python-utils/src/taproot.rs	`51.54% <23.68%> (-15.67%)`	:arrow_down:

... and 8 files with indirect coverage changes

storopoli commented 3 weeks ago

Cache is rugpulling me in the CI failure but this runs OK locally and used to run fine here also (don't know what's happening)

Rajil1213 commented 3 weeks ago

Cache is rugpulling me in the CI failure but this runs OK locally and used to run fine here also (don't know what's happening)

Does removing the if check in the Install dependencies step help? I think python is smart enough to not reinstall deps if the version has not changed.

On an unrelated point, a bigger issue that I just now discovered is that cargo b --workspace fails on mac with the arm chips even after setting PYTHON_CONFIGURE_OPTS="--enable-shared" as suggested in the pyo3 user guide. Will post something on Slack to see if anybody else is facing the same issue. On the other hand, poetry install --no-root works just fine 🤷 .

storopoli commented 3 weeks ago

Cache is rugpulling me in the CI failure but this runs OK locally and used to run fine here also (don't know what's happening)

Does removing the if check in the Install dependencies step help? I think python is smart enough to not reinstall deps if the version has not changed.

On an unrelated point, a bigger issue that I just now discovered is that cargo b --workspace fails on mac with the arm chips even after setting PYTHON_CONFIGURE_OPTS="--enable-shared" as suggested in the pyo3 user guide. Will post something on Slack to see if anybody else is facing the same issue. On the other hand, poetry install --no-root works just fine 🤷 .

I have a Mac now and I don't have that ENV var and poetry install --no-root works.

Rajil1213 commented 3 weeks ago

I have a Mac now and I don't have that ENV var and poetry install --no-root works.

Yeah that works. Does cargo b --workspace work too?

storopoli commented 3 weeks ago

I have a Mac now and I don't have that ENV var and poetry install --no-root works.

Yeah that works. Does cargo b --workspace work too?

No, mine is broken as well :(

Rajil1213 commented 3 weeks ago

No, mine is broken as well :(

Could you create a ticket for this? It's not a blocker for this PR specifically. But it is definitely a blocker for almost any development on main (at least for the majority of people that are now using a mac with arm chips).

storopoli commented 3 weeks ago

No, mine is broken as well :(

Could you create a ticket for this? It's not a blocker for this PR specifically. But it is definitely a blocker for almost any development on main (at least for the majority of people that are now using a mac with arm chips).

https://alpenlabs.atlassian.net/browse/STR-541

storopoli commented 3 weeks ago

This looks good broadly aside from the, like, major issue with it.

What is the major issue?

alpenlabs / strata